Skip to content
This repository was archived by the owner on May 31, 2020. It is now read-only.

call plugin onChange method#3

Open
hosmelq wants to merge 1 commit into
draft-js-plugins:masterfrom
hosmelq:call-plugin-onchange-method
Open

call plugin onChange method#3
hosmelq wants to merge 1 commit into
draft-js-plugins:masterfrom
hosmelq:call-plugin-onchange-method

Conversation

@hosmelq

@hosmelq hosmelq commented Oct 2, 2018

Copy link
Copy Markdown
Collaborator

No description provided.

@juliankrispel

Copy link
Copy Markdown
Member

@hosmelq I actually think removing onChange from plugin methods simplifies the API. It's also little bit confusing, like - as a user I'm not sure if this means I'm listening to events or updating the state, in the previous versions of plugins this is both - which is imo super confusing.

I don't think it's needed really...

@hosmelq

hosmelq commented Oct 3, 2018

Copy link
Copy Markdown
Collaborator Author

Perfect, I like the idea. You can close this whenever you want.

@juliankrispel

juliankrispel commented Oct 3, 2018 via email

Copy link
Copy Markdown
Member

@hosmelq

hosmelq commented Oct 8, 2018

Copy link
Copy Markdown
Collaborator Author

Gracias @juliankrispel, no sé mucho sobre borrador, pero podría ayudar. 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants